]> git.ipfire.org Git - thirdparty/tor.git/commit
Remove abort handler from the backtrace generator
authorcypherpunks <cypherpunks@torproject.org>
Sun, 18 Dec 2016 15:55:37 +0000 (15:55 +0000)
committerNick Mathewson <nickm@torproject.org>
Fri, 23 Dec 2016 15:54:17 +0000 (10:54 -0500)
commit04f21f03221a3888bde376ee1c2daa1effccbb4e
treeabb7dc2d13c444706764163fa772b557578c9582
parentd3c0b137aff9ae506778c74d885088cbdb535922
Remove abort handler from the backtrace generator

The abort handler masks the exit status of the backtrace generator by
capturing the abort signal from the backtrace handler and exiting with
zero. Because the output of the backtrace generator is meant to be piped
to `bt_test.py`, its exit status is unimportant and is currently
ignored.

The abort handler calls `exit(3)` which is not asynchronous-signal-safe
and calling it in this context is undefined behavior [0].

Closes ticket 21026.

[0] https://www.securecoding.cert.org/confluence/x/34At
changes/ticket21026 [new file with mode: 0644]
src/test/test_bt_cl.c