]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: cs35l34: Fix GPIO name and drop legacy include
authorLinus Walleij <linus.walleij@linaro.org>
Fri, 1 Dec 2023 13:20:32 +0000 (14:20 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Mar 2024 14:48:34 +0000 (14:48 +0000)
commit05059601518eb93b185a2c4d462102c01fb0d7a2
tree0ffdc45c31ce727b05f7a98d7824d4b3953798fb
parentd3d782b5a5d341a479039a9197348f4e94bb44c0
ASoC: cs35l34: Fix GPIO name and drop legacy include

[ Upstream commit a6122b0b4211d132934ef99e7b737910e6d54d2f ]

This driver includes the legacy GPIO APIs <linux/gpio.h> and
<linux/of_gpio.h> but does not use any symbols from any of
them.

Drop the includes.

Further the driver is requesting "reset-gpios" rather than
just "reset" from the GPIO framework. This is wrong because
the gpiolib core will add "-gpios" before processing the
request from e.g. device tree. Drop the suffix.

The last problem means that the optional RESET GPIO has
never been properly retrieved and used even if it existed,
but nobody noticed.

Fixes: c1124c09e103 ("ASoC: cs35l34: Initial commit of the cs35l34 CODEC driver.")
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20231201-descriptors-sound-cirrus-v2-3-ee9f9d4655eb@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/cs35l34.c