]> git.ipfire.org Git - thirdparty/libvirt.git/commit
virnetdaemon: Don't deadlock when talking to D-Bus
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 1 Sep 2017 08:33:12 +0000 (10:33 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 1 Sep 2017 11:21:33 +0000 (13:21 +0200)
commit054c6d27214ef90feab3897b052f450492d5ef3f
tree5fb4e21de28e4da42b44331b2bb4305630e39c55
parent9820756cd33467815af6d68b2ceef4e567646ec4
virnetdaemon: Don't deadlock when talking to D-Bus

https://bugzilla.redhat.com/show_bug.cgi?id=1487322

In ace45e67abbd I tried to fix a problem that we get the reply to
a D-Bus call while we were sleeping. In that case the callback
was never set. So I changed the code that the callback is called
directly in this case. However, I hadn't realized that since the
callback is called out of order it locks the virNetDaemon.
Exactly the very same virNetDaemon object that we are dealing
with right now and that we have locked already (in
virNetDaemonAddShutdownInhibition())

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/rpc/virnetdaemon.c