]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tracing: Properly process error handling in event_hist_trigger_parse()
authorMiaoqian Lin <linmq006@gmail.com>
Thu, 11 Dec 2025 10:00:58 +0000 (14:00 +0400)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 26 Jan 2026 22:00:50 +0000 (17:00 -0500)
commit0550069cc25f513ce1f109c88f7c1f01d63297db
treebc627e0d4771707aa8362f71fb12af665ecf1a7b
parent63804fed149a6750ffd28610c5c1c98cce6bd377
tracing: Properly process error handling in event_hist_trigger_parse()

Memory allocated with trigger_data_alloc() requires trigger_data_free()
for proper cleanup.

Replace kfree() with trigger_data_free() to fix this.

Found via static analysis and code review.

This isn't a real bug due to the current code basically being an open
coded version of trigger_data_free() without the synchronization. The
synchronization isn't needed as this is the error path of creation and
there's nothing to synchronize against yet. Replace the kfree() to be
consistent with the allocation.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Tom Zanussi <zanussi@kernel.org>
Link: https://patch.msgid.link/20251211100058.2381268-1-linmq006@gmail.com
Fixes: e1f187d09e11 ("tracing: Have existing event_command.parse() implementations use helpers")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_hist.c