]> git.ipfire.org Git - thirdparty/gcc.git/commit
aarch64: Fix TImode __sync_*_compare_and_exchange expansion with LSE [PR114310]
authorJakub Jelinek <jakub@redhat.com>
Thu, 14 Mar 2024 13:09:20 +0000 (14:09 +0100)
committerJakub Jelinek <jakub@redhat.com>
Thu, 20 Jun 2024 13:07:37 +0000 (15:07 +0200)
commit0570303f818ed12ff28de0d258ebe4f6803ef7e0
tree924915b8a57e5cc087fe74ae80a64b64b61661f8
parentf340e1fb0e0bbe5f2982f3f1025bb12fb910db41
aarch64: Fix TImode __sync_*_compare_and_exchange expansion with LSE [PR114310]

The following testcase ICEs with LSE atomics.
The problem is that the @atomic_compare_and_swap<mode> expander uses
aarch64_reg_or_zero predicate for the desired operand, which is fine,
given that for most of the modes and even for TImode in some cases
it can handle zero immediate just fine, but the TImode
@aarch64_compare_and_swap<mode>_lse just uses register_operand for
that operand instead, again intentionally so, because the casp,
caspa, caspl and caspal instructions need to use a pair of consecutive
registers for the operand and xzr is just one register and we can't
just store zero into the link register to emulate pair of zeros.

So, the following patch fixes that by forcing the newval operand into
a register for the TImode LSE case.

2024-03-14  Jakub Jelinek  <jakub@redhat.com>

PR target/114310
* config/aarch64/aarch64.c (aarch64_expand_compare_and_swap): For
TImode force newval into a register.

* gcc.dg/pr114310.c: New test.

(cherry picked from commit 9349aefa1df7ae36714b7b9f426ad46e314892d1)
gcc/config/aarch64/aarch64.c
gcc/testsuite/gcc.dg/pr114310.c [new file with mode: 0644]