]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nvme-multipath: drop optimization for static ANA group IDs
authorHannes Reinecke <hare@suse.de>
Wed, 9 Jan 2019 08:45:15 +0000 (09:45 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Mar 2019 16:59:41 +0000 (17:59 +0100)
commit0581ea5469a6440eac207b225145bb6b45f43756
treedbc4a8aaaba9c54d3384077506d068cecdcdcc0b
parent161acb8d61dc1f31ebc29d91cb41bd3a6f39e668
nvme-multipath: drop optimization for static ANA group IDs

[ Upstream commit 78a61cd42a64f3587862b372a79e1d6aaf131fd7 ]

Bit 6 in the ANACAP field is used to indicate that the ANA group ID
doesn't change while the namespace is attached to the controller.
There is an optimisation in the code to only allocate space
for the ANA group header, as the namespace list won't change and
hence would not need to be refreshed.
However, this optimisation was never carried over to the actual
workflow, which always assumes that the buffer is large enough
to hold the ANA header _and_ the namespace list.
So drop this optimisation and always allocate enough space.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvme/host/multipath.c