]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
vsock/virtio: fix potential unbounded skb queue
authorEric Dumazet <edumazet@google.com>
Thu, 30 Apr 2026 12:26:52 +0000 (12:26 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 5 May 2026 02:12:37 +0000 (19:12 -0700)
commit059b7dbd20a6f0c539a45ddff1573cb8946685b5
tree3ff47e158434a15b5f48cd8a668fb1e4a7690548
parent36bdc0e815b4e8a05b9028d8ef8a25e1ead35cc1
vsock/virtio: fix potential unbounded skb queue

virtio_transport_inc_rx_pkt() checks vvs->rx_bytes + len > vvs->buf_alloc.

virtio_transport_recv_enqueue() skips coalescing for packets
with VIRTIO_VSOCK_SEQ_EOM.

If fed with packets with len == 0 and VIRTIO_VSOCK_SEQ_EOM,
a very large number of packets can be queued
because vvs->rx_bytes stays at 0.

Fix this by estimating the skb metadata size:

(Number of skbs in the queue) * SKB_TRUESIZE(0)

Fixes: 077706165717 ("virtio/vsock: don't use skbuff state to account credit")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: "Eugenio Pérez" <eperezma@redhat.com>
Cc: virtualization@lists.linux.dev
Link: https://patch.msgid.link/20260430122653.554058-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/vmw_vsock/virtio_transport_common.c