]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vsock: prevent unnecessary refcnt inc for nonblocking connect
authorEiichi Tsukata <eiichi.tsukata@nutanix.com>
Tue, 9 Nov 2021 00:15:02 +0000 (00:15 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:36:16 +0000 (11:36 +0100)
commit0608664fb50441224458e944efec167869b3f8a1
tree4dfb5fed23b90a17a3b8364e16d39a6e54526bec
parent5b4bf87e96f2eb319bd6830935becea4a94e17ec
vsock: prevent unnecessary refcnt inc for nonblocking connect

[ Upstream commit c7cd82b90599fa10915f41e3dd9098a77d0aa7b6 ]

Currently vosck_connect() increments sock refcount for nonblocking
socket each time it's called, which can lead to memory leak if
it's called multiple times because connect timeout function decrements
sock refcount only once.

Fixes it by making vsock_connect() return -EALREADY immediately when
sock state is already SS_CONNECTING.

Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/vmw_vsock/af_vsock.c