]> git.ipfire.org Git - thirdparty/openssl.git/commit
Make DH_check set some error bits in recently added error
authorBernd Edlinger <bernd.edlinger@hotmail.de>
Sun, 23 Jul 2023 12:27:54 +0000 (14:27 +0200)
committerBernd Edlinger <bernd.edlinger@hotmail.de>
Wed, 26 Jul 2023 11:19:53 +0000 (13:19 +0200)
commit06bbee97aaa6b1998d05e03825a750f40fc836ea
treec3a26c0ec9a71ef48dde0057c5376a828075f373
parent33d03540d7c54e75d3d645b19ea7142782974b86
Make DH_check set some error bits in recently added error

The pre-existing error cases where DH_check returned zero
are not related to the dh params in any way, but are only
triggered by out-of-memory errors, therefore having *ret
set to zero feels right, but since the new error case is
triggered by too large p values that is something different.
On the other hand some callers of this function might not
be prepared to handle the return value correctly but only
rely on *ret. Therefore we set some error bits in *ret as
additional safety measure.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21524)

(cherry picked from commit 81d10e61a4b7d5394d08a718bf7d6bae20e818fc)
crypto/dh/dh_check.c