]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-34521: Fix tests in test_multiprocessing_spawn to use correctly CMSG_SPACE (GH...
authorPablo Galindo <Pablogsal@gmail.com>
Fri, 28 Sep 2018 09:51:05 +0000 (10:51 +0100)
committerVictor Stinner <vstinner@redhat.com>
Fri, 28 Sep 2018 09:51:05 +0000 (02:51 -0700)
commit077061a7b24917aaf31057885c69919c5a553c88
treeec0abb12b7da3ec882d82b31589def05ec4454dc
parent1fba2ffc37da52c08db51fe4360459990b0311c9
bpo-34521: Fix tests in test_multiprocessing_spawn to use correctly CMSG_SPACE (GH-9613)

After some failures in AMD64 FreeBSD CURRENT Debug 3.x buildbots
regarding tests in test_multiprocessing_spawn and after examining
similar failures in test_socket, some errors in the calculation of
ancillary data buffers were found in multiprocessing.reduction.

CMSG_LEN() can often be used as the buffer size for recvmsg() to
receive a single item of ancillary data, but RFC 3542 requires portable
applications to use CMSG_SPACE() and thus include space for padding,
even when the item will be the last in the buffer.

The failures we experience are due to the usage of CMSG_LEN() instead of
CMSG_SPACE().
Lib/multiprocessing/reduction.py