]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: lpfc: Fix possible memory leak in lpfc_rcv_padisc()
authorJustin Tee <justin.tee@broadcom.com>
Wed, 31 Jan 2024 18:50:57 +0000 (10:50 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 11:07:34 +0000 (13:07 +0200)
commit07a2aa674fca679316b8ac51440adb895b53a7cf
tree9afd7ec586feda80a907a1e02cee933de441d1be
parent89e8524135a3902e7563a5a59b7b5ec1bf4904ac
scsi: lpfc: Fix possible memory leak in lpfc_rcv_padisc()

[ Upstream commit 2ae917d4bcab80ab304b774d492e2fcd6c52c06b ]

The call to lpfc_sli4_resume_rpi() in lpfc_rcv_padisc() may return an
unsuccessful status.  In such cases, the elsiocb is not issued, the
completion is not called, and thus the elsiocb resource is leaked.

Check return value after calling lpfc_sli4_resume_rpi() and conditionally
release the elsiocb resource.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20240131185112.149731-3-justintee8345@gmail.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/lpfc/lpfc_nportdisc.c