]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging: most: avoid null pointer dereference when iface is null
authorColin Ian King <colin.king@canonical.com>
Wed, 24 Jun 2020 16:39:57 +0000 (17:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Aug 2020 06:23:47 +0000 (08:23 +0200)
commit07bb7df94438743374dc2bf4e37123c6fe7d19ca
treef569e826f39fdcba62860eeb8905eabe9808808f
parentc62689ff0de8efc9aea03e1c1bec81a271ef96c5
staging: most: avoid null pointer dereference when iface is null

[ Upstream commit e4463e49e29f43eecec86e2e2b2e2ab4feb7d867 ]

In the case where the pointer iface is null then the reporting of this
error will dereference iface when printing an error message causing which
is not ideal.  Since the majority of callers to most_register_interface
report an error when -EINVAL is returned a simple fix is to just remove
the error message, I doubt it will be missed.

Addresses-Coverity: ("Dereference after null check")
Fixes: 57562a72414c ("Staging: most: add MOST driver's core module")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200624163957.11676-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/most/core.c