]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
greybus: arche-ctrl: move device table to its right location
authorArnd Bergmann <arnd@arndb.de>
Wed, 3 Apr 2024 08:06:35 +0000 (10:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:39:35 +0000 (13:39 +0200)
commit088139c9d36d4fd826c6f208affdfc656e097266
tree3ff23da437c4d6f9f4e8c43cf7a9426919cbbfc6
parentb0008a4c83a6db64ff292f3abd0574885af0302d
greybus: arche-ctrl: move device table to its right location

[ Upstream commit 6a0b8c0da8d8d418cde6894a104cf74e6098ddfa ]

The arche-ctrl has two platform drivers and three of_device_id tables,
but one table is only used for the the module loader, while the other
two seem to be associated with their drivers.

This leads to a W=1 warning when the driver is built-in:

drivers/staging/greybus/arche-platform.c:623:34: error: 'arche_combined_id' defined but not used [-Werror=unused-const-variable=]
  623 | static const struct of_device_id arche_combined_id[] = {

Drop the extra table and register both tables that are actually
used as the ones for the module loader instead.

Fixes: 7b62b61c752a ("greybus: arche-ctrl: Don't expose driver internals to arche-platform driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240403080702.3509288-18-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/greybus/arche-apb-ctrl.c
drivers/staging/greybus/arche-platform.c