]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bpf: Fix bpf_put_raw_tracepoint()'s use of __module_address()
authorAndrii Nakryiko <andrii@kernel.org>
Thu, 3 Dec 2020 20:46:21 +0000 (12:46 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:51:18 +0000 (11:51 +0100)
commit08e22710601a33464cbec3d2d371cb992738256c
treed7b5d275342319e8c02c55bda5b7439ad2a78e1b
parente02d218aa63d20db01ed3af17fa3b5b33f7c02b0
bpf: Fix bpf_put_raw_tracepoint()'s use of __module_address()

[ Upstream commit 12cc126df82c96c89706aa207ad27c56f219047c ]

__module_address() needs to be called with preemption disabled or with
module_mutex taken. preempt_disable() is enough for read-only uses, which is
what this fix does. Also, module_put() does internal check for NULL, so drop
it as well.

Fixes: a38d1107f937 ("bpf: support raw tracepoints in modules")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20201203204634.1325171-2-andrii@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/trace/bpf_trace.c