]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: hda: Fix potential access overflow in beep helper
authorTakashi Iwai <tiwai@suse.de>
Tue, 7 Apr 2020 08:44:01 +0000 (10:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Apr 2020 05:58:52 +0000 (07:58 +0200)
commit08f1f7271b76c93ef593e006b46c00042fac7250
treee28dae2e95df17f68f8cf6175a40a6b73ab96845
parentfeef183962f831194940cbffae46e743390c78d8
ALSA: hda: Fix potential access overflow in beep helper

commit 0ad3f0b384d58f3bd1f4fb87d0af5b8f6866f41a upstream.

The beep control helper function blindly stores the values in two
stereo channels no matter whether the actual control is mono or
stereo.  This is practically harmless, but it annoys the recently
introduced sanity check, resulting in an error when the checker is
enabled.

This patch corrects the behavior to store only on the defined array
member.

Fixes: 0401e8548eac ("ALSA: hda - Move beep helper functions to hda_beep.c")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207139
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200407084402.25589-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/hda/hda_beep.c