]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nilfs2: replace WARN_ONs by nilfs_error for checkpoint acquisition failure
authorRyusuke Konishi <konishi.ryusuke@gmail.com>
Thu, 29 Sep 2022 12:33:30 +0000 (21:33 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Oct 2022 06:01:41 +0000 (08:01 +0200)
commit090fcfb6edeb9367a915b2749e2bd1f8b48d8898
treec9429d9aee60239b72e34f168c70359eefb6f75c
parent4755fcd844240857b525f6e8d8b65ee140fe9570
nilfs2: replace WARN_ONs by nilfs_error for checkpoint acquisition failure

commit 723ac751208f6d6540191689cfbf6c77135a7a1b upstream.

If creation or finalization of a checkpoint fails due to anomalies in the
checkpoint metadata on disk, a kernel warning is generated.

This patch replaces the WARN_ONs by nilfs_error, so that a kernel, booted
with panic_on_warn, does not panic.  A nilfs_error is appropriate here to
handle the abnormal filesystem condition.

This also replaces the detected error codes with an I/O error so that
neither of the internal error codes is returned to callers.

Link: https://lkml.kernel.org/r/20220929123330.19658-1-konishi.ryusuke@gmail.com
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Reported-by: syzbot+fbb3e0b24e8dae5a16ee@syzkaller.appspotmail.com
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nilfs2/segment.c