]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: x86/crct10dif-pcl - fix use via crypto_shash_digest()
authorEric Biggers <ebiggers@google.com>
Sun, 31 Mar 2019 20:04:13 +0000 (13:04 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 23 Sep 2019 20:11:40 +0000 (21:11 +0100)
commit09401a34c11a2f01e5c76dd1733d563cd5eeeaf7
treebbc4df461c8da2f60d2d200c5206957d710aa76d
parent00c649ff2e87add15d293ca6c52180b215b8a4bd
crypto: x86/crct10dif-pcl - fix use via crypto_shash_digest()

commit dec3d0b1071a0f3194e66a83d26ecf4aa8c5910e upstream.

The ->digest() method of crct10dif-pclmul reads the current CRC value
from the shash_desc context.  But this value is uninitialized, causing
crypto_shash_digest() to compute the wrong result.  Fix it.

Probably this wasn't noticed before because lib/crc-t10dif.c only uses
crypto_shash_update(), not crypto_shash_digest().  Likewise,
crypto_shash_digest() is not yet tested by the crypto self-tests because
those only test the ahash API which only uses shash init/update/final.

Fixes: 0b95a7f85718 ("crypto: crct10dif - Glue code to cast accelerated CRCT10DIF assembly as a crypto transform")
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/x86/crypto/crct10dif-pclmul_glue.c