]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
powerpc/rtas: Prevent Spectre v1 gadget construction in sys_rtas()
authorNathan Lynch <nathanl@linux.ibm.com>
Fri, 31 May 2024 00:44:12 +0000 (19:44 -0500)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 28 Jun 2024 12:28:58 +0000 (22:28 +1000)
commit0974d03eb479384466d828d65637814bee6b26d7
tree9e61fa2740cb95cd3bb6a215534c526c025724a2
parentd5d1a1a55a7f227c0f41847b0598982f0a93170d
powerpc/rtas: Prevent Spectre v1 gadget construction in sys_rtas()

Smatch warns:

  arch/powerpc/kernel/rtas.c:1932 __do_sys_rtas() warn: potential
  spectre issue 'args.args' [r] (local cap)

The 'nargs' and 'nret' locals come directly from a user-supplied
buffer and are used as indexes into a small stack-based array and as
inputs to copy_to_user() after they are subject to bounds checks.

Use array_index_nospec() after the bounds checks to clamp these values
for speculative execution.

Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
Reported-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240530-sys_rtas-nargs-nret-v1-1-129acddd4d89@linux.ibm.com
arch/powerpc/kernel/rtas.c