]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bnxt_en: Do not modify max IRQ count after RDMA driver requests/frees IRQs.
authorMichael Chan <michael.chan@broadcom.com>
Mon, 9 Jul 2018 06:24:51 +0000 (02:24 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Aug 2018 11:07:05 +0000 (13:07 +0200)
commit09a63bc8c2d4d41f58f6c381b2d312b4b08c0faf
tree5bea8c80f7b7377bf33384cee8a06fed78576ff5
parente678c47251bedef1cf9bbcb967e02305e6780b87
bnxt_en: Do not modify max IRQ count after RDMA driver requests/frees IRQs.

[ Upstream commit 30f529473ec962102e8bcd33a6a04f1e1b490ae2 ]

Calling bnxt_set_max_func_irqs() to modify the max IRQ count requested or
freed by the RDMA driver is flawed.  The max IRQ count is checked when
re-initializing the IRQ vectors and this can happen multiple times
during ifup or ethtool -L.  If the max IRQ is reduced and the RDMA
driver is operational, we may not initailize IRQs correctly.  This
problem shows up on VFs with very small number of MSIX.

There is no other logic that relies on the IRQ count excluding the ones
used by RDMA.  So we fix it by just removing the call to subtract or
add the IRQs used by RDMA.

Fixes: a588e4580a7e ("bnxt_en: Add interface to support RDMA driver.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c
drivers/net/ethernet/broadcom/bnxt/bnxt.h
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c