]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
perf tools: Fix get_max_num() size_t underflow on empty sysfs file
authorArnaldo Carvalho de Melo <acme@redhat.com>
Sat, 6 Jun 2026 23:37:52 +0000 (20:37 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 10 Jun 2026 14:38:45 +0000 (11:38 -0300)
commit0a012113bb3a44482c163f16f4db03ccaa37a339
tree1541ed1052bdb09de11d9df71ce18a4754d3a962
parentf54ce06049bf716f6b1e3a78e72360d583ea2acb
perf tools: Fix get_max_num() size_t underflow on empty sysfs file

get_max_num() reads a sysfs file (cpu/possible, cpu/present, or
node/possible) and scans backward from the end to find the last
number.  If the file is empty, filename__read_str() returns num == 0.
The loop `while (--num)` decrements the size_t from 0 to SIZE_MAX,
reading backward across the heap until a comma or hyphen is found
or unmapped memory is hit.

Add an early return for empty files before the backward scan.

Fixes: 7780c25bae59fd04 ("perf tools: Allow ability to map cpus to nodes easily")
Reported-by: sashiko-bot <sashiko-bot@kernel.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Ian Rogers <irogers@google.com>
Assisted-by: Claude:claude-opus-4.6
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/cpumap.c