]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix TestLib::slurp_file() with offset on windows.
authorAndres Freund <andres@anarazel.de>
Mon, 4 Oct 2021 20:28:06 +0000 (13:28 -0700)
committerAndres Freund <andres@anarazel.de>
Mon, 4 Oct 2021 20:33:12 +0000 (13:33 -0700)
commit0a134c860fc116a3f1eed71fbdcf48b66221b456
treec2049243491f3777491b611380982a35bac427b1
parentd0b0b70dc2a60d68f97af5264fe432e245eea3a5
Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de
Backpatch: 9.6-, like 3c5b0685b921
src/test/perl/TestLib.pm