]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/msm: use trylock for debugfs
authorRob Clark <robdclark@chromium.org>
Sun, 29 Jun 2025 20:13:22 +0000 (13:13 -0700)
committerRob Clark <robin.clark@oss.qualcomm.com>
Sat, 5 Jul 2025 00:48:38 +0000 (17:48 -0700)
commit0a1ff88ec5b60b41ba830c5bf08b6cd8f45ab411
tree5eab214c81db6b6a3beafe1b98c99ea0c81a4693
parent05a249683455bf1099de28d7f189c6013aae4794
drm/msm: use trylock for debugfs

This resolves a potential deadlock vs msm_gem_vm_close().  Otherwise for
_NO_SHARE buffers msm_gem_describe() could be trying to acquire the
shared vm resv, while already holding priv->obj_lock.  But _vm_close()
might drop the last reference to a GEM obj while already holding the vm
resv, and msm_gem_free_object() needs to grab priv->obj_lock, a locking
inversion.

OTOH this is only for debugfs and it isn't critical if we undercount by
skipping a locked obj.  So just use trylock() and move along if we can't
get the lock.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
Tested-by: Antonino Maniscalco <antomani103@gmail.com>
Reviewed-by: Antonino Maniscalco <antomani103@gmail.com>
Patchwork: https://patchwork.freedesktop.org/patch/661525/
drivers/gpu/drm/msm/msm_gem.c
drivers/gpu/drm/msm/msm_gem.h