]> git.ipfire.org Git - thirdparty/git.git/commit
submodule--helper: don't leak {run,capture}_command() cp.dir argument
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Wed, 31 Aug 2022 23:14:12 +0000 (01:14 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 2 Sep 2022 16:18:12 +0000 (09:18 -0700)
commit0a4d31537d66bd2249adc8d923e2e6829204059e
tree8b1bd2812a9dc69c193679c3495e0a52cea6b67a
parent4b9d12460d18d02bf6f12cc3c96340e53acf03e3
submodule--helper: don't leak {run,capture}_command() cp.dir argument

Fix a memory leak in c51f8f94e5b (submodule--helper: run update
procedures from C, 2021-08-24) and 3c3558f0953 (submodule--helper: run
update using child process struct, 2022-03-15) by not allocating
memory in the first place.

The "dir" member of "struct child_process" will not be modified by
that API, and it's declared to be "const char *". So let's not
needlessly duplicate these strings.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: Glen Choo <chooglen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/submodule--helper.c