]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bnx2x: Fix busy_poll vs netpoll
authorEric Dumazet <edumazet@google.com>
Wed, 15 Apr 2015 01:45:00 +0000 (18:45 -0700)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 27 Apr 2015 20:48:30 +0000 (16:48 -0400)
commit0a50f4197fe67d3d9273728640bc8d4e19e33bbc
treec3894be6837064d061b5169560d27ef016ffeded
parent73b4de2b9d32bdddd3b9d304cdc448b7ea2e0ee3
bnx2x: Fix busy_poll vs netpoll

[ Upstream commit 074975d0374333f656c48487aa046a21a9b9d7a1 ]

Commit 9a2620c877454 ("bnx2x: prevent WARN during driver unload")
switched the napi/busy_lock locking mechanism from spin_lock() into
spin_lock_bh(), breaking inter-operability with netconsole, as netpoll
disables interrupts prior to calling our napi mechanism.

This switches the driver into using atomic assignments instead of the
spinlock mechanisms previously employed.

Based on initial patch from Yuval Mintz & Ariel Elior

I basically added softirq starvation avoidance, and mixture
of atomic operations, plain writes and barriers.

Note this slightly reduces the overhead for this driver when no
busy_poll sockets are in use.

Fixes: 9a2620c877454 ("bnx2x: prevent WARN during driver unload")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c