]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
select: Fix unbalanced user_access_end()
authorChristophe Leroy <christophe.leroy@csgroup.eu>
Mon, 13 Jan 2025 08:37:24 +0000 (09:37 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:49:51 +0000 (12:49 +0100)
commit0a60270ee48cbfc22d622fb2346971d62e61d625
tree21c193e75ce7f8df1e8f08570f1ba86c5cb4c867
parentb9ca509e5b7fc463cbf9de9db3fca7bd8039519e
select: Fix unbalanced user_access_end()

[ Upstream commit 344af27715ddbf357cf76978d674428b88f8e92d ]

While working on implementing user access validation on powerpc
I got the following warnings on a pmac32_defconfig build:

  CC      fs/select.o
fs/select.o: warning: objtool: sys_pselect6+0x1bc: redundant UACCESS disable
fs/select.o: warning: objtool: sys_pselect6_time32+0x1bc: redundant UACCESS disable

On powerpc/32s, user_read_access_begin/end() are no-ops, but the
failure path has a user_access_end() instead of user_read_access_end()
which means an access end without any prior access begin.

Replace that user_access_end() by user_read_access_end().

Fixes: 7e71609f64ec ("pselect6() and friends: take handling the combined 6th/7th args into helper")
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Link: https://lore.kernel.org/r/a7139e28d767a13e667ee3c79599a8047222ef36.1736751221.git.christophe.leroy@csgroup.eu
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/select.c