]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
firmware: arm_scmi: Support loop control in quirk code snippets
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 16 Mar 2026 15:34:40 +0000 (16:34 +0100)
committerSudeep Holla <sudeep.holla@kernel.org>
Tue, 17 Mar 2026 07:30:22 +0000 (07:30 +0000)
commit0a7ec808abecaf0d5c3ecc0d1b87d58f29c85604
treea8d855ef7bb4af37c812df07ed8ef63e5d35945b
parent09bb95d63adeaab7b07127cfce4ecbeff9ab6488
firmware: arm_scmi: Support loop control in quirk code snippets

Each SCMI firmware quirk contains a code snippet, which handles the
quirk, and has full access to the surrounding context.  When this
context is (part of) a loop body, the code snippet may want to use loop
control statements like "break" and "continue".  Unfortunately the
SCMI_QUIRK() macro implementation contains a dummy loop, taking
precedence over any outer loops.  Hence quirk code cannot use loop
control statements, but has to resort to polluting the surrounding
context with a label, and use goto.

Fix this by replacing the "do { ... } while (0)" construct in the
SCMI_QUIRK() implementation by "({ ... })".

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Message-Id: <51de914cddef8fa86c2e7dd5397e5df759c45464.1773675224.git.geert+renesas@glider.be>
Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
drivers/firmware/arm_scmi/quirks.h