]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: rawmidi: Avoid bit fields for state flags
authorTakashi Iwai <tiwai@suse.de>
Fri, 14 Feb 2020 11:13:16 +0000 (12:13 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2020 14:42:55 +0000 (15:42 +0100)
commit0aa6ce52d38e3b4d257c9d314208f83781ef4854
tree62d110c94f3f9b9a4880d1bc17b07668dee392a5
parent61faa537979103e4a55714a4c0e17153485e9d39
ALSA: rawmidi: Avoid bit fields for state flags

commit dfa9a5efe8b932a84b3b319250aa3ac60c20f876 upstream.

The rawmidi state flags (opened, append, active_sensing) are stored in
bit fields that can be potentially racy when concurrently accessed
without any locks.  Although the current code should be fine, there is
also no any real benefit by keeping the bitfields for this kind of
short number of members.

This patch changes those bit fields flags to the simple bool fields.
There should be no size increase of the snd_rawmidi_substream by this
change.

Reported-by: syzbot+576cc007eb9f2c968200@syzkaller.appspotmail.com
Link: https://lore.kernel.org/r/20200214111316.26939-4-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/sound/rawmidi.h