]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fs/nls: Fix utf16 to utf8 conversion
authorArmin Wolf <W_Armin@gmx.de>
Tue, 11 Nov 2025 13:11:22 +0000 (14:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 12:55:16 +0000 (13:55 +0100)
commit0aba4b43a27bf06e68bdd9e61f3108d7631ffd71
treec9a057f27ebd221c79cb04d696c2b93edf617a6c
parentef7a9c2fae3251af92f92895063732d0c9695e0d
fs/nls: Fix utf16 to utf8 conversion

[ Upstream commit 25524b6190295577e4918c689644451365e6466d ]

Currently the function responsible for converting between utf16 and
utf8 strings will ignore any characters that cannot be converted. This
however also includes multi-byte characters that do not fit into the
provided string buffer.

This can cause problems if such a multi-byte character is followed by
a single-byte character. In such a case the multi-byte character might
be ignored when the provided string buffer is too small, but the
single-byte character might fit and is thus still copied into the
resulting string.

Fix this by stop filling the provided string buffer once a character
does not fit. In order to be able to do this extend utf32_to_utf8()
to return useful errno codes instead of -1.

Fixes: 74675a58507e ("NLS: update handling of Unicode")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://patch.msgid.link/20251111131125.3379-2-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nls/nls_base.c