]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netfilter: nf_log: release skbuff on nlmsg put failure
authorHoucheng Lin <houcheng@gmail.com>
Thu, 23 Oct 2014 08:36:08 +0000 (10:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Nov 2014 17:23:15 +0000 (09:23 -0800)
commit0adb674c9a102ca1c0d28fc127d8ce250168c3a9
tree9b74edaeca7ab0a4f55898b05785c7cf2548872c
parent7fa9b25d1e404346ee1483bc1d050955be475bf6
netfilter: nf_log: release skbuff on nlmsg put failure

commit b51d3fa364885a2c1e1668f88776c67c95291820 upstream.

The kernel should reserve enough room in the skb so that the DONE
message can always be appended.  However, in case of e.g. new attribute
erronously not being size-accounted for, __nfulnl_send() will still
try to put next nlmsg into this full skbuf, causing the skb to be stuck
forever and blocking delivery of further messages.

Fix issue by releasing skb immediately after nlmsg_put error and
WARN() so we can track down the cause of such size mismatch.

[ fw@strlen.de: add tailroom/len info to WARN ]

Signed-off-by: Houcheng Lin <houcheng@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nfnetlink_log.c