]> git.ipfire.org Git - thirdparty/asterisk.git/commit
app_queue: Only do announcement logic between ringing cycles
authorStefanEng86 <stefanen@kth.se>
Fri, 15 Sep 2017 07:59:59 +0000 (09:59 +0200)
committerJoshua Colp <jcolp@digium.com>
Thu, 21 Sep 2017 10:04:55 +0000 (07:04 -0300)
commit0adf6f3bd9d5645bd6654fbb200767824a494cb4
tree2991b765dcf2f6461a9a784d7f8c28402fb99228
parent844f70f3011c6c812a2bd52b2bd3c4a6c5dba17f
app_queue: Only do announcement logic between ringing cycles

This patch reverts the change by patch 2263 from old reviewboard.
Note that reverting that 2263-patch still preserves the behaviour that
the commit log of the 2263-patch claimed to add. The reason for this is:

The function wait_for_answer is only called from try_calling which
in turn is only called from the main for loop in queue_exec, and
earlier in that loop we already check the things that's removed by
this patch. There's no need to check those things twice each loop
iteration, and I think the proper place to check it is before each
ringing cycle. By checking it in wait_for_answer, you allow the issue
explained in the jira - that the head caller hears announcements while
the agents' sip phones are actively ringing.

Reported-by: Stefan Engström
Tested-by: Stefan Engström
ASTERISK-27216 #close

Change-Id: Ic4290dc75256f9743900c6762ee1bb915f672db0
apps/app_queue.c