]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix query result leak during binary upgrade
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 15 May 2024 20:48:51 +0000 (22:48 +0200)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 15 May 2024 20:48:51 +0000 (22:48 +0200)
commit0ae05c18e0bf740e6457e710f9323e75f6619c35
tree1477180b6bde72251a2ed9c30074b7de5322f364
parent315661ecafbcbb23116cceea2ea80657d7763af0
Fix query result leak during binary upgrade

9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the
outer level, but left the PQclear and query buffer destruction in the
is_index conditional.  353708e1fb2d fixed the leak of the query buffer
but left the PGresult leak. This moves clearing the result to the outer
level ensuring that it will be called.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/374550C1-F4ED-4D9D-9498-0FD029CCF674@yesql.se
Backpatch-through: v15
src/bin/pg_dump/pg_dump.c