]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ipv4: ip_check_defrag should correctly check return value of skb_copy_bits
authorAlexander Drozdov <al.drozdov@gmail.com>
Tue, 17 Feb 2015 10:33:46 +0000 (13:33 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Mar 2015 12:31:21 +0000 (13:31 +0100)
commit0b04f65d11c1889908fd7594cbd015bcd2c640dd
treee46d74040f7af57bdce36fb186f7a4e756c1c70b
parentf1796b116e46cd8c341e9b08d8aa1f3d5cc6f818
ipv4: ip_check_defrag should correctly check return value of skb_copy_bits

[ Upstream commit fba04a9e0c869498889b6445fd06cbe7da9bb834 ]

skb_copy_bits() returns zero on success and negative value on error,
so it is needed to invert the condition in ip_check_defrag().

Fixes: 1bf3751ec90c ("ipv4: ip_check_defrag must not modify skb before unsharing")
Signed-off-by: Alexander Drozdov <al.drozdov@gmail.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/ip_fragment.c