]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
USB: xhci: Reset a halted endpoint immediately when we encounter a stall.
authorMathias Nyman <mathias.nyman@linux.intel.com>
Tue, 18 Nov 2014 09:27:12 +0000 (11:27 +0200)
committerJiri Slaby <jslaby@suse.cz>
Wed, 7 Jan 2015 15:20:14 +0000 (16:20 +0100)
commit0b71fc5fa4e7b22d022f3ebe0652f7ddabc1e41d
tree8f4461eec9f54c26b4182b5af7d8a781e2848e96
parentfd120bec1cfd1e12f996081c367a6600832fa811
USB: xhci: Reset a halted endpoint immediately when we encounter a stall.

commit 8e71a322fdb127814bcba423a512914ca5bc6cf5 upstream.

If a device is halted and reuturns a STALL, then the halted endpoint
needs to be cleared both on the host and device side. The host
side halt is cleared by issueing a xhci reset endpoint command. The device side
is cleared with a ClearFeature(ENDPOINT_HALT) request, which should
be issued by the device driver if a URB reruen -EPIPE.

Previously we cleared the host side halt after the device side was cleared.
To make sure the host side halt is cleared in time we want to issue the
reset endpoint command immedialtely when a STALL status is encountered.

Otherwise we end up not following the specs and not returning -EPIPE
several times in a row when trying to transfer data to a halted endpoint.

Fixes: bcef3fd (USB: xhci: Handle errors that cause endpoint halts.)
Tested-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/usb/host/xhci-ring.c
drivers/usb/host/xhci.c