]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
usb: ulpi: fix memory leak on ulpi_register() error paths
authorFelix Gu <ustc.gu@gmail.com>
Tue, 7 Apr 2026 13:21:22 +0000 (21:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Apr 2026 15:49:43 +0000 (09:49 -0600)
commit0b9fcab1b8608d429e5f239afb197de928d4de7d
tree7f990ba6ff34452cd2853c8a59f8cd7e13f715dc
parent3f91484f6c13c434bd573ca6b6779c26adb0ddab
usb: ulpi: fix memory leak on ulpi_register() error paths

Commit 01af542392b5 ("usb: ulpi: fix double free in
ulpi_register_interface() error path") removed kfree(ulpi) from
ulpi_register_interface() to fix a double-free when device_register()
fails.

But when ulpi_of_register() or ulpi_read_id() fail before
device_register() is called, the ulpi allocation is leaked.

Add kfree(ulpi) on both error paths to properly clean up the allocation.

Fixes: 01af542392b5 ("usb: ulpi: fix double free in ulpi_register_interface() error path")
Cc: stable <stable@kernel.org>
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://patch.msgid.link/20260407-ulpi-v1-1-f3fafe53f7b2@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/common/ulpi.c