]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
[PATCH] run_posix_cpu_timers: remove a bogus BUG_ON() (CVE-2006-2445)
authorOleg Nesterov <oleg@tv-sign.ru>
Thu, 15 Jun 2006 16:11:43 +0000 (20:11 +0400)
committerChris Wright <chrisw@sous-sol.org>
Tue, 20 Jun 2006 08:54:53 +0000 (01:54 -0700)
commit0ba239cc0ef0ebf9d38cd733754fcf657ae79b2b
tree4c1f0987b6c29f8fd26f0f3ab92c1d3c5dc9ba6e
parent5705264e83bd9f8918895d8f5ddddbdeb062c719
[PATCH] run_posix_cpu_timers: remove a bogus BUG_ON() (CVE-2006-2445)

do_exit() clears ->it_##clock##_expires, but nothing prevents
another cpu to attach the timer to exiting process after that.
arm_timer() tries to protect against this race, but the check
is racy.

After exit_notify() does 'write_unlock_irq(&tasklist_lock)' and
before do_exit() calls 'schedule() local timer interrupt can find
tsk->exit_state != 0. If that state was EXIT_DEAD (or another cpu
does sys_wait4) interrupted task has ->signal == NULL.

At this moment exiting task has no pending cpu timers, they were
cleanuped in __exit_signal()->posix_cpu_timers_exit{,_group}(),
so we can just return from irq.

John Stultz recently confirmed this bug, see

http://marc.theaimsgroup.com/?l=linux-kernel&m=115015841413687

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
kernel/exit.c
kernel/posix-cpu-timers.c