]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
block, bfq: remove wrong lock in bfq_requests_merged
authorFilippo Muzzini <filippo.muzzini@outlook.it>
Thu, 31 May 2018 13:23:11 +0000 (15:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Aug 2018 05:47:39 +0000 (07:47 +0200)
commit0ba8e51fbac29efda0d48437959f5bb068b82cd7
treea0c95626a73d8d62f74db670405d574837578176
parente631f675763b13c357b17bce8ef5afd997b487e1
block, bfq: remove wrong lock in bfq_requests_merged

[ Upstream commit a12bffebc0c9d6a5851f062aaea3aa7c4adc6042 ]

In bfq_requests_merged(), there is a deadlock because the lock on
bfqq->bfqd->lock is held by the calling function, but the code of
this function tries to grab the lock again.

This deadlock is currently hidden by another bug (fixed by next commit
for this source file), which causes the body of bfq_requests_merged()
to be never executed.

This commit removes the deadlock by removing the lock/unlock pair.

Signed-off-by: Filippo Muzzini <filippo.muzzini@outlook.it>
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
block/bfq-iosched.c