]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
can: at91_can: Fix memory leak in at91_can_probe()
authorZilin Guan <zilin@seu.edu.cn>
Thu, 22 Jan 2026 11:41:28 +0000 (11:41 +0000)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 22 Jan 2026 15:56:26 +0000 (16:56 +0100)
commit0baa4d3170d72a2a8dc93bf729d6d04ad113dc72
tree5c930a93eeac9a0ebb11dca63d69d6df08ef1be9
parent5778d65d4b85d4929d30998863e08e20af4b6113
can: at91_can: Fix memory leak in at91_can_probe()

In at91_can_probe(), the dev structure is allocated via alloc_candev().
However, if the subsequent call to devm_phy_optional_get() fails, the
code jumps directly to exit_iounmap, missing the call to free_candev().
This results in a memory leak of the allocated net_device structure.

Fix this by jumping to the exit_free label instead, which ensures that
free_candev() is called to properly release the memory.

Compile tested only. Issue found using a prototype static analysis tool
and code review.

Fixes: 3ecc09856afb ("can: at91_can: add CAN transceiver support")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Link: https://patch.msgid.link/20260122114128.643752-1-zilin@seu.edu.cn
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/at91_can.c