]> git.ipfire.org Git - thirdparty/linux.git/commit
x86/cpu: Drop vestigial PBE logic in AMD/Hygon/Centaur/Cyrix
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 26 Nov 2025 12:51:47 +0000 (12:51 +0000)
committerIngo Molnar <mingo@kernel.org>
Sun, 14 Dec 2025 08:57:13 +0000 (09:57 +0100)
commit0bc03750deefc5fdab77b01c459bb1691c64c3c5
tree2443b567c90a8b5c80fae278ca82f3bf19c4526b
parenta2aabcfc6015b6196f161b6bf4df1519ab09c3e1
x86/cpu: Drop vestigial PBE logic in AMD/Hygon/Centaur/Cyrix

Besides formatting changes, this logic dates back to Linux 2.4.0-test11 in
November 2000.

Prior to "Massive cleanup of CPU detection and bug handling",
c->x86_capability was a single u32 containing cpuid(1).edx,
cpuid(0x80000001).edx, or a synthesis thereof.  X86_FEATURE_AMD3D was
defined as the top bit this single u32.

After "Massive cleanup of CPU detection and bug handling",
c->x86_capability became an array with AMD's extended feature leaf split
away from Intel's basic feature leaf.

AMD doc #20734-G states that 3DNow is only enumerated in the extended
feature leaf, and that other vendors where using this bit too.  i.e. AMD
never produced a CPU which set bit 31 in the basic leaf, meaning that
there's nothing to clear out in the first place.

This logic looks like it was relevant in the pre-"Massive cleanup" world
but ought to have been dropped when c->x86_capability was properly split.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Pu Wen <puwen@hygon.cn>
Link: https://patch.msgid.link/20251126125147.880275-1-andrew.cooper3@citrix.com
arch/x86/kernel/cpu/amd.c
arch/x86/kernel/cpu/centaur.c
arch/x86/kernel/cpu/cyrix.c
arch/x86/kernel/cpu/hygon.c