]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dql: Fix dql->limit value when reset.
authorJing Su <jingsusu@didiglobal.com>
Wed, 19 Mar 2025 08:57:51 +0000 (16:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:41:55 +0000 (14:41 +0200)
commit0c2aa72f4f35235828b406001e4b935cdab0c06f
tree3c086be45bebb0b2884981cf83f3ab95f83db453
parent3854f4e98ef22f6fc6d693f56832a6639a034a9e
dql: Fix dql->limit value when reset.

[ Upstream commit 3a17f23f7c36bac3a3584aaf97d3e3e0b2790396 ]

Executing dql_reset after setting a non-zero value for limit_min can
lead to an unreasonable situation where dql->limit is less than
dql->limit_min.

For instance, after setting
/sys/class/net/eth*/queues/tx-0/byte_queue_limits/limit_min,
an ifconfig down/up operation might cause the ethernet driver to call
netdev_tx_reset_queue, which in turn invokes dql_reset.

In this case, dql->limit is reset to 0 while dql->limit_min remains
non-zero value, which is unexpected. The limit should always be
greater than or equal to limit_min.

Signed-off-by: Jing Su <jingsusu@didiglobal.com>
Link: https://patch.msgid.link/Z9qHD1s/NEuQBdgH@pilot-ThinkCentre-M930t-N000
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
lib/dynamic_queue_limits.c