]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-119592: gh-152967: Fix ProcessPoolExecutor stranding submitted work when a max_tas...
authorGregory P. Smith <68491+gpshead@users.noreply.github.com>
Wed, 8 Jul 2026 20:06:20 +0000 (13:06 -0700)
committerGitHub <noreply@github.com>
Wed, 8 Jul 2026 20:06:20 +0000 (13:06 -0700)
commit0c6422ff6a13ae309493fb7a358cb35d7ea959c8
treef52d79420162c0557b1a4e175ede541b20fe98e0
parentc843cb758e56c2b759860504849250ee152b89dd
gh-119592: gh-152967: Fix ProcessPoolExecutor stranding submitted work when a max_tasks_per_child worker exits (GH-152978)

gh-119592: Fix ProcessPoolExecutor stranding submitted work when a max_tasks_per_child worker exits

Worker replacement went through the executor object: the manager thread
read executor attributes that shutdown(wait=False) clears concurrently,
and could not replace workers at all once the executor was garbage
collected. A worker exiting at its max_tasks_per_child limit in those
states left the remaining submitted work permanently unexecuted and hung
interpreter exit; the racing case could crash the manager thread.

Replace workers from the executor manager thread using its own state
plus configuration read through the live executor weakref, which
shutdown() never clears:

- After shutdown(wait=False) with the executor still referenced, a
  replacement is spawned and the remaining work is executed as
  documented.
- Once the executor has been garbage collected (gh-152967), or a
  replacement worker cannot be started and no workers remain, the
  remaining futures now fail with BrokenProcessPool instead of never
  resolving.
- A new _force_shutting_down flag stops both spawn paths from starting
  workers that would escape terminate_workers()/kill_workers().

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Reviewed-multiple-times-by: Gregory P. Smith
Lib/concurrent/futures/process.py
Lib/test/test_concurrent_futures/test_process_pool.py
Misc/NEWS.d/next/Library/2026-07-03-18-30-00.gh-issue-119592.mQr3Vx.rst [new file with mode: 0644]