]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
pnfs/flexfiles: Fix memory leak in nfs4_ff_alloc_deviceid_node()
authorZilin Guan <zilin@seu.edu.cn>
Thu, 25 Dec 2025 07:41:03 +0000 (07:41 +0000)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 5 Jan 2026 04:03:25 +0000 (23:03 -0500)
commit0c728083654f0066f5e10a1d2b0bd0907af19a58
tree87c7dd371257703bc76d2b204919f3bd1a6508ba
parentcce0be6eb4971456b703aaeafd571650d314bcca
pnfs/flexfiles: Fix memory leak in nfs4_ff_alloc_deviceid_node()

In nfs4_ff_alloc_deviceid_node(), if the allocation for ds_versions fails,
the function jumps to the out_scratch label without freeing the already
allocated dsaddrs list, leading to a memory leak.

Fix this by jumping to the out_err_drain_dsaddrs label, which properly
frees the dsaddrs list before cleaning up other resources.

Fixes: d67ae825a59d6 ("pnfs/flexfiles: Add the FlexFile Layout Driver")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/flexfilelayout/flexfilelayoutdev.c