]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hwmon: (max16065) Fix overflows seen when writing limits
authorGuenter Roeck <linux@roeck-us.net>
Thu, 18 Jul 2024 16:52:01 +0000 (09:52 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:29:05 +0000 (16:29 +0200)
commit0c7af15f64b6f68539fbee8411f7126fa6acb613
tree33886cf6398e890dcf5fef47b9d3dbac3a16ed56
parentf606b9ac4abbe56816eee1941dccae9b6d3d8952
hwmon: (max16065) Fix overflows seen when writing limits

[ Upstream commit 744ec4477b11c42e2c8de9eb8364675ae7a0bd81 ]

Writing large limits resulted in overflows as reported by module tests.

in0_lcrit: Suspected overflow: [max=5538, read 0, written 2147483647]
in0_crit: Suspected overflow: [max=5538, read 0, written 2147483647]
in0_min: Suspected overflow: [max=5538, read 0, written 2147483647]

Fix the problem by clamping prior to multiplications and the use of
DIV_ROUND_CLOSEST, and by using consistent variable types.

Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Fixes: f5bae2642e3d ("hwmon: Driver for MAX16065 System Manager and compatibles")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/max16065.c