]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mlx5e: Fix use-after-free when reverting termination table
authorRoi Dayan <roid@nvidia.com>
Mon, 14 Nov 2022 18:04:29 +0000 (20:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Dec 2022 10:23:55 +0000 (11:23 +0100)
commit0d2f9d95d9fbe993f3c4bafb87d59897b0325aff
treeb35e7da8df551f6f23e90ce614e5b27d4a1f7c97
parent2cb84ff34938cc3cdfe2d90e70cf8a8ced66fd1e
net/mlx5e: Fix use-after-free when reverting termination table

[ Upstream commit 52c795af04441d76f565c4634f893e5b553df2ae ]

When having multiple dests with termination tables and second one
or afterwards fails the driver reverts usage of term tables but
doesn't reset the assignment in attr->dests[num_vport_dests].termtbl
which case a use-after-free when releasing the rule.
Fix by resetting the assignment of termtbl to null.

Fixes: 10caabdaad5a ("net/mlx5e: Use termination table for VLAN push actions")
Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Maor Dickman <maord@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c