]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: ti-vpe: Fix a missing check and reference count leak
authorQiushi Wu <wu000273@umn.edu>
Sun, 14 Jun 2020 02:56:05 +0000 (04:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 08:03:02 +0000 (09:03 +0100)
commit0d35b8ae3006001f4fc260f87a1dcd81ce5f9c1c
treec893c26eb0990cf4078f252cb7aae976064e1545
parenta138371ca26b8a9ddf31c19192dbefa085e80307
media: ti-vpe: Fix a missing check and reference count leak

[ Upstream commit 7dae2aaaf432767ca7aa11fa84643a7c2600dbdd ]

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
And also, when the call of function vpe_runtime_get() failed,
we won't call vpe_runtime_put().
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails
inside vpe_runtime_get().

Fixes: 4571912743ac ("[media] v4l: ti-vpe: Add VPE mem to mem driver")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/ti-vpe/vpe.c