]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: fix missing cleanup on error in qemuSaveImageStartVM
authorAni Sinha <ani@anisinha.ca>
Wed, 15 Dec 2021 13:07:21 +0000 (18:37 +0530)
committerJiri Denemark <jdenemar@redhat.com>
Thu, 16 Dec 2021 09:32:10 +0000 (10:32 +0100)
commit0d5b08e56da338342c97cc663ae70840fd13d2f6
treebc3ec96bd59d59c68d25d37d31d82df3487d5e83
parentf8915af663a1337ee64418e1ad7e6f380f5dc10b
qemu: fix missing cleanup on error in qemuSaveImageStartVM

Commit 52521de8332c2323bd ("qemu: Use qemuDomainSaveStatus") replaced a call
to virDomainObjSave() with qemuDomainSaveStatus() as a part of cleanup. Since
qemuDomainSaveStatus() does not indicate any failure through its return code,
the error handling cleanup code got eliminated in the process. Thus upon
failure, we will no longer killing the started qemu process. This commit fixes
this by reverting the change that was introduced with the above commit.

Fixes: 52521de8332c2323bd ("qemu: Use qemuDomainSaveStatus")
Signed-off-by: Ani Sinha <ani@anisinha.ca>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_saveimage.c