]> git.ipfire.org Git - thirdparty/haproxy.git/commit
projects / thirdparty / haproxy.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7a0139e) | patch
BUG/MAJOR: hpack: fix length check for short names encoding
authorWilly Tarreau <w@1wt.eu>
Sun, 16 Dec 2018 08:38:30 +0000 (09:38 +0100)
committerWilly Tarreau <w@1wt.eu>
Sun, 16 Dec 2018 08:38:30 +0000 (09:38 +0100)
commit0dc1b84839ef235a3153d1ef3e729fe1c89f2ea9
tree6e62c98980f301cf7139bf215dc9cf7cad00f91ctree | snapshot
parent7a0139e2b688986c88caa23b76e82e7c1b5fef5fcommit | diff
BUG/MAJOR: hpack: fix length check for short names encoding

Commit 19ed92b ("MINOR: hpack: optimize header encoding for short names")
introduced an error in the space computation for short names, as it removed
the length encoding from the count without replacing with 1 (the minimum
byte). This results in the last byte of the area being occasionally
overwritten, which is immediately detected with -DDEBUG_MEMORY_POOLS as
the canary at the end gets overwritten.

No backport is needed.
src/hpack-enc.c diff | blob | blame | history
Mirror of https://github.com/haproxy/haproxy.git