]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
target/iscsi: Fix np_ip bracket issue by removing np_ip
authorAndy Grover <agrover@redhat.com>
Mon, 24 Aug 2015 17:26:03 +0000 (10:26 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Oct 2015 21:49:14 +0000 (14:49 -0700)
commit0df8a7a1a277c20fa8e55afbdbdacd7eb7c2aed4
treee290cf19eaf24af8ee63bb90de6cf4cb8434c403
parentd6402e4ecf0d9a3ec9ceee9d218dcc7605611df7
target/iscsi: Fix np_ip bracket issue by removing np_ip

commit 76c28f1fcfeb42b47f798fe498351ee1d60086ae upstream.

Revert commit 1997e6259, which causes double brackets on ipv6
inaddr_any addresses.

Since we have np_sockaddr, if we need a textual representation we can
use "%pISc".

Change iscsit_add_network_portal() and iscsit_add_np() signatures to remove
*ip_str parameter.

Fix and extend some comments earlier in the function.

Tested to work for :: and ::1 via iscsiadm, previously :: failed, see
https://bugzilla.redhat.com/show_bug.cgi?id=1249107 .

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/target/iscsi/iscsi_target.c
drivers/target/iscsi/iscsi_target.h
drivers/target/iscsi/iscsi_target_configfs.c
drivers/target/iscsi/iscsi_target_login.c
drivers/target/iscsi/iscsi_target_tpg.c
drivers/target/iscsi/iscsi_target_tpg.h
include/target/iscsi/iscsi_target_core.h