]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
perf annotate: Fix build with NO_SLANG=1
authorNamhyung Kim <namhyung@kernel.org>
Tue, 21 Oct 2025 03:07:50 +0000 (12:07 +0900)
committerNamhyung Kim <namhyung@kernel.org>
Tue, 21 Oct 2025 12:36:02 +0000 (05:36 -0700)
commit0e6c07a3c30cdc4509fc5e7dc490d4cc6e5c241a
treefdc7f2c89c887bc62153b41ca7dfa7bc18f30c1a
parent29166bd0a41fe6bdcf0b2376ef57e358c8a1e988
perf annotate: Fix build with NO_SLANG=1

The recent change for perf c2c annotate broke build without slang
support like below.

  builtin-annotate.c: In function 'hists__find_annotations':
  builtin-annotate.c:522:73: error: 'NO_ADDR' undeclared (first use in this function); did you mean 'NR_ADDR'?
    522 |                         key = hist_entry__tui_annotate(he, evsel, NULL, NO_ADDR);
        |                                                                         ^~~~~~~
        |                                                                         NR_ADDR
  builtin-annotate.c:522:73: note: each undeclared identifier is reported only once for each function it appears in

  builtin-annotate.c:522:31: error: too many arguments to function 'hist_entry__tui_annotate'
    522 |                         key = hist_entry__tui_annotate(he, evsel, NULL, NO_ADDR);
        |                               ^~~~~~~~~~~~~~~~~~~~~~~~
  In file included from util/sort.h:6,
                   from builtin-annotate.c:28:
  util/hist.h:756:19: note: declared here
    756 | static inline int hist_entry__tui_annotate(struct hist_entry *he __maybe_unused,
        |                   ^~~~~~~~~~~~~~~~~~~~~~~~

And I noticed that it missed to update the other side of #ifdef
HAVE_SLANG_SUPPORT.  Let's fix it.

Cc: Tianyou Li <tianyou.li@intel.com>
Fixes: cd3466cd2639783d ("perf c2c: Add annotation support to perf c2c report")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/hist.h