]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bridge: Only call /sbin/bridge-stp for the initial network namespace
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Tue, 5 Jan 2016 09:46:00 +0000 (10:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 31 Jan 2016 19:25:50 +0000 (11:25 -0800)
commit0e6f38960cfdc8597056529de7def7a035f905fb
treede332e3b4ee1cc26b8fc704935ba291c77cfd4ae
parent9b8b611fe0f86f07a4ff4a5f3bcb0ea7ceb7da3b
bridge: Only call /sbin/bridge-stp for the initial network namespace

[ Upstream commit ff62198553e43cdffa9d539f6165d3e83f8a42bc ]

[I stole this patch from Eric Biederman. He wrote:]

> There is no defined mechanism to pass network namespace information
> into /sbin/bridge-stp therefore don't even try to invoke it except
> for bridge devices in the initial network namespace.
>
> It is possible for unprivileged users to cause /sbin/bridge-stp to be
> invoked for any network device name which if /sbin/bridge-stp does not
> guard against unreasonable arguments or being invoked twice on the
> same network device could cause problems.

[Hannes: changed patch using netns_eq]

Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/bridge/br_stp_if.c