]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
firmware: arm_scmi: Fix unused notifier-block in unregister
authorAmitai Gottlieb <amitaig@hailo.ai>
Tue, 16 Dec 2025 11:50:09 +0000 (13:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 11 Jan 2026 14:22:33 +0000 (15:22 +0100)
commit0e8ac70521e679fd0e1eca86a536aa797db38b15
tree7f5cae37536d8e4428e711ee702327e8aafd75c9
parent21e82354cdd7c954dbcf3e06d8536b40d2813c16
firmware: arm_scmi: Fix unused notifier-block in unregister

In scmi_devm_notifier_unregister(), the notifier-block argument was ignored
and never passed to devres_release(). As a result, the function always
returned -ENOENT and failed to unregister the notifier.

Drivers that depend on this helper for teardown could therefore hit
unexpected failures, including kernel panics.

Commit 264a2c520628 ("firmware: arm_scmi: Simplify scmi_devm_notifier_unregister")
removed the faulty code path during refactoring and hence this fix is not
required upstream.

Cc: <stable@vger.kernel.org> # 5.15.x, 6.1.x, and 6.6.x
Fixes: 5ad3d1cf7d34 ("firmware: arm_scmi: Introduce new devres notification ops")
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Amitai Gottlieb <amitaig@hailo.ai>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/arm_scmi/notify.c